ci: pin golangci-lint and align local lint with CI diff filter#515
Merged
Conversation
✅ Deploy Preview for devsydev canceled.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughPins Changesgolangci-lint v2.12.2 upgrade and local task rename
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Deploy Preview for images-devsy-sh canceled.
|
Pre-commit pinned an older golangci-lint (v2.11.4) and ran without the diff filter that CI applies, so violations introduced by a patch could pass locally and fail in CI. Match versions, mirror the --new-from-rev=origin/main filter in the hook, and rename the Taskfile target to cli:lint:ci so "did I match CI?" is a single command.
skevetter
force-pushed
the
fix/lint-ci-parity
branch
from
June 21, 2026 22:38
7ddf0c8 to
09812a5
Compare
skevetter
marked this pull request as ready for review
June 22, 2026 19:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Local lint and CI lint disagreed because of two things, both addressed here:
golangci-linttov2.11.4; CI usedlatest(currently resolved tov2.12.2). Linter rules and thresholds shift across versions, so the same code could pass one and fail the other.cli:lint:newwas close, but the name didn't make the parity intent obvious.Changes
.github/workflows/pr-ci.yml— pingolangci-lintfromlatesttov2.12.2. CI no longer drifts when upstream releases..pre-commit-config.yaml— bump pinned versionv2.11.4 -> v2.12.2to match CI exactly.Taskfile.yml— replacecli:lint:newwithcli:lint:ci(clearer name, same command). Runtask cli:lint:cifor an explicit "did I match CI?" check.Why no
--new-from-revin pre-commitInitially attempted, but
actions/checkout@v6defaults to a shallow fetch that doesn't includeorigin/main, so--new-from-rev=origin/maincouldn't resolve in the precommit job and golangci-lint fell back to all-issues mode, surfacing 15 pre-existingunparamviolations introduced by the v2.11.4→v2.12.2 detection improvements. The Taskfile target gives developers the diff-filter on demand without breaking pre-commit.Summary by CodeRabbit